-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix conda support and keep API compatibility #536
Conversation
Thanks. Glad to see an integration test of nni! I'll see if I can make this more elegant and neat, in case some changes of our internal APIs break tianshou's test in future. |
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 94.03% 93.75% -0.28%
==========================================
Files 63 63
Lines 4306 4322 +16
==========================================
+ Hits 4049 4052 +3
- Misses 257 270 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Let me know if nni's current CI pipeline works or not with 0.4.6.post1 version via pip install. |
The problem is resolved. Thank you so much. |
The nni test fails again: https://github.com/thu-ml/tianshou/actions/runs/3125052390/jobs/5069025377 |
Fixed in #750. |
* loose constrains * fix nni issue (thu-ml#478) * fix coverage
conda-forge/tianshou-feedstock#13
Add nni test in CI pipeline, only runs in GPU_test