Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conda support and keep API compatibility #536

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

Trinkle23897
Copy link
Collaborator

@Trinkle23897 Trinkle23897 commented Feb 25, 2022

conda-forge/tianshou-feedstock#13

Add nni test in CI pipeline, only runs in GPU_test

@ultmaster
Copy link
Contributor

ultmaster commented Feb 25, 2022

Thanks. Glad to see an integration test of nni!

I'll see if I can make this more elegant and neat, in case some changes of our internal APIs break tianshou's test in future.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #536 (4930772) into master (97df511) will decrease coverage by 0.27%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   94.03%   93.75%   -0.28%     
==========================================
  Files          63       63              
  Lines        4306     4322      +16     
==========================================
+ Hits         4049     4052       +3     
- Misses        257      270      +13     
Flag Coverage Δ
unittests 93.75% <41.66%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/env/worker/base.py 62.96% <28.57%> (-11.46%) ⬇️
tianshou/env/__init__.py 66.66% <50.00%> (-33.34%) ⬇️
tianshou/policy/multiagent/mapolicy.py 83.90% <50.00%> (-1.81%) ⬇️
tianshou/__init__.py 100.00% <100.00%> (ø)
tianshou/env/venvs.py 91.71% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97df511...4930772. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit c248b4f into thu-ml:master Feb 25, 2022
@Trinkle23897 Trinkle23897 deleted the fix-setup branch February 25, 2022 16:05
@Trinkle23897
Copy link
Collaborator Author

Let me know if nni's current CI pipeline works or not with 0.4.6.post1 version via pip install.

@ultmaster
Copy link
Contributor

Let me know if nni's current CI pipeline works or not with 0.4.6.post1 version via pip install.

The problem is resolved. Thank you so much.

@Trinkle23897
Copy link
Collaborator Author

@ultmaster
Copy link
Contributor

BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
* loose constrains

* fix nni issue (thu-ml#478)

* fix coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants