Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Multi-agent RL docs, upgrade pettingzoo #595

Merged
merged 4 commits into from
Apr 16, 2022

Conversation

ycheng517
Copy link
Contributor

@ycheng517 ycheng517 commented Apr 15, 2022

  • I have marked all applicable categories:

    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)

  • I have checked the code using make commit-checks (required)

  • If applicable, I have mentioned the relevant/related issue(s)

  • If applicable, I have listed every items in this Pull Request below

  • updated documentation for multi-agent RL to reflect updates made in Pettingzoo #494

  • upgrade pettingzoo version to latest

  • some small fixes to remove exceptions and deprecation warnings with the latest pettingzoo version

Copy link
Collaborator

@Trinkle23897 Trinkle23897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -46,7 +46,7 @@ def get_extras_require() -> str:
"doc8",
"scipy",
"pillow",
"pettingzoo>=1.12",
"pettingzoo>=1.17",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just good to keep the dependencies up-to-date in general

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #595 (d87f813) into master (1827749) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   93.51%   93.44%   -0.08%     
==========================================
  Files          66       66              
  Lines        4428     4426       -2     
==========================================
- Hits         4141     4136       -5     
- Misses        287      290       +3     
Flag Coverage Δ
unittests 93.44% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/env/pettingzoo_env.py 90.90% <100.00%> (-0.40%) ⬇️
tianshou/policy/modelfree/trpo.py 88.52% <0.00%> (-4.92%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 merged commit 6fc6857 into thu-ml:master Apr 16, 2022
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
* update multi-agent docs, upgrade pettingzoo

* avoid pettingzoo deprecation warning

* fix pistonball tests

* codestyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants