-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Multi-agent RL docs, upgrade pettingzoo #595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -46,7 +46,7 @@ def get_extras_require() -> str: | |||
"doc8", | |||
"scipy", | |||
"pillow", | |||
"pettingzoo>=1.12", | |||
"pettingzoo>=1.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just good to keep the dependencies up-to-date in general
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 93.51% 93.44% -0.08%
==========================================
Files 66 66
Lines 4428 4426 -2
==========================================
- Hits 4141 4136 -5
- Misses 287 290 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
* update multi-agent docs, upgrade pettingzoo * avoid pettingzoo deprecation warning * fix pistonball tests * codestyle
I have marked all applicable categories:
I have reformatted the code using
make format
(required)I have checked the code using
make commit-checks
(required)If applicable, I have mentioned the relevant/related issue(s)
If applicable, I have listed every items in this Pull Request below
updated documentation for multi-agent RL to reflect updates made in Pettingzoo #494
upgrade pettingzoo version to latest
some small fixes to remove exceptions and deprecation warnings with the latest pettingzoo version