-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BranchDQN for large discrete action spaces #618
Conversation
Could you please resolve the merge conflict? |
@Trinkle23897 Could you check now? And please let me know if you have any comment :) |
Thanks, will do it today. |
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
+ Coverage 93.55% 93.66% +0.10%
==========================================
Files 69 71 +2
Lines 4608 4733 +125
==========================================
+ Hits 4311 4433 +122
- Misses 297 300 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Done! the checks have passed! Ready to merge 🥳 |
Is it possible to make unit test faster, by tuning the hyperparameter?
BDQ test is 4x slower than TD3... |
Yes, I think it can be done. For now, the hyperparameters are not tuned yet. Which tool would you recommend for this? |
Hmm... I don't have a specific recommendation because the current hparam for all test scripts are tuned by my hand lol Maybe increase the learning rate and eps decay as the first step to see if it can work with 10 different seeds? |
Tuned hyper-parameteres for bdq_test.py, now it runs almost 10 times faster 😃
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two slight issues.
Co-authored-by: Jiayi Weng <trinkle23897@qq.com>
make format
(required)make commit-checks
(required)