Convert RL Unplugged Atari datasets to tianshou ReplayBuffer #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 93.48% 93.54% +0.06%
==========================================
Files 67 67
Lines 4433 4433
==========================================
+ Hits 4144 4147 +3
+ Misses 289 286 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Also, could you please write something in readme to demonstrate the step-by-step conversion process of rl-unplugged dataset? |
Trinkle23897
approved these changes
Apr 29, 2022
8 tasks
Comment on lines
+202
to
+204
| batch = _tf_example_to_tianshou_batch(example) | ||
| buffer.add(batch) | ||
| cnt += 1 |
There was a problem hiding this comment.
It's better to use a batch-style process instead of a for-loop, e.g., directly set buffer._meta.obs = ... (or maybe we should create another API to support this thing?)
For example,
buffer = ReplayBuffer(500000)
# add first batch to initialize memory
batch = ...
buffer.add(batch)
# then directly set, I know it's ugly but this is the general idea
meta = buffer._meta
meta.obs = ...
meta.act = ...
...
buffer._meta = meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make format(required)make commit-checks(required)Add a script to convert RL Unplugged Atari datasets to tianshou ReplayBuffer for better benchmarks. #612