Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement REDQ based on original contribution by @Jimenius #623

Merged
merged 3 commits into from
Apr 30, 2022

Conversation

nuance1979
Copy link
Collaborator

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

Following discussion in #514, I take the REDQ code out and submit them as an independent PR. Most credit goes to @Jimenius .

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2022

Codecov Report

Merging #623 (d25da3b) into master (41afc25) will increase coverage by 0.02%.
The diff coverage is 87.69%.

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   93.54%   93.56%   +0.02%     
==========================================
  Files          67       68       +1     
  Lines        4433     4556     +123     
==========================================
+ Hits         4147     4263     +116     
- Misses        286      293       +7     
Flag Coverage Δ
unittests 93.56% <87.69%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/redq.py 84.84% <84.84%> (ø)
tianshou/utils/net/common.py 92.18% <95.65%> (+0.52%) ⬆️
tianshou/env/pettingzoo_env.py 91.48% <100.00%> (+0.58%) ⬆️
tianshou/policy/__init__.py 100.00% <100.00%> (ø)
tianshou/utils/net/continuous.py 97.91% <100.00%> (ø)
tianshou/policy/base.py 80.89% <0.00%> (+5.73%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 merged commit dd16818 into thu-ml:master Apr 30, 2022
@Trinkle23897 Trinkle23897 mentioned this pull request May 2, 2022
9 tasks
@nuance1979 nuance1979 deleted the redq branch May 3, 2022 23:38
@MischaPanch MischaPanch mentioned this pull request Oct 14, 2023
9 tasks
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Co-authored-by: Minhui Li
 <limh@lamda.nju.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants