Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 bugs and refactor RunningMeanStd to support dict obs norm #695

Merged
merged 4 commits into from
Jul 15, 2022

Conversation

Trinkle23897
Copy link
Collaborator

close #672, #688, #689, #691

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #695 (b96cfb0) into master (6505484) will increase coverage by 0.16%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   93.25%   93.42%   +0.16%     
==========================================
  Files          72       72              
  Lines        4890     4894       +4     
==========================================
+ Hits         4560     4572      +12     
+ Misses        330      322       -8     
Flag Coverage Δ
unittests 93.42% <93.75%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/env/worker/ray.py 76.59% <0.00%> (ø)
tianshou/data/collector.py 94.24% <100.00%> (ø)
tianshou/env/venv_wrappers.py 83.33% <100.00%> (-2.39%) ⬇️
tianshou/env/worker/dummy.py 76.47% <100.00%> (ø)
tianshou/env/worker/subproc.py 87.02% <100.00%> (ø)
tianshou/utils/statistics.py 100.00% <100.00%> (ø)
tianshou/utils/logger/tensorboard.py 95.45% <0.00%> (+20.45%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 changed the title Fix 2 bugs and support dict obs norm Fix 2 bugs and refactor RunningMeanStd to support dict obs norm Jul 15, 2022
@Trinkle23897 Trinkle23897 merged commit 99c99bb into thu-ml:master Jul 15, 2022
@Trinkle23897 Trinkle23897 deleted the bug-fix branch July 15, 2022 05:53
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment