Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix venv wrapper reset retval error with gym env #712

Merged
merged 2 commits into from
Jul 31, 2022

Conversation

Trinkle23897
Copy link
Collaborator

Close #697

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022

Codecov Report

Merging #712 (d384cc2) into master (f270e88) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          72       72           
  Lines        4895     4895           
=======================================
  Hits         4564     4564           
  Misses        331      331           
Flag Coverage Δ
unittests 93.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/data/collector.py 94.24% <ø> (ø)
tianshou/env/venvs.py 94.07% <ø> (ø)
tianshou/env/venv_wrappers.py 83.33% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 merged commit 0f59e38 into thu-ml:master Jul 31, 2022
@Trinkle23897 Trinkle23897 deleted the fix-gym-reset-info branch July 31, 2022 18:00
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
* Fix venv wrapper reset retval error with gym env

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in obs norm
2 participants