-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pre-commit #752
Added pre-commit #752
Conversation
Markus28
commented
Sep 26, 2022
•
edited
Loading
edited
- This PR adds the checks that are defined in the Makefile as pre-commit hooks.
- Hopefully, the checks are equivalent to those from the Makefile, but I can't guarantee it.
- CI remains as it is.
- As I pointed out on discord, I experienced some conflicts between flake8 and yapf, so it might be better to transition to some other combination (e.g. black).
Sorry, I ran the wrong python version. It appears mypy isn't happy on Python 3.7. I added the ignore hints back. |
I needed to add some new |
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
- Coverage 90.53% 89.42% -1.12%
==========================================
Files 70 70
Lines 4925 4925
==========================================
- Hits 4459 4404 -55
- Misses 466 521 +55
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'd like to remove mypy in pre-commit because it has inconsistent behaviors with different python version and os, which will block contributors living in non py38+ubuntu2004 |
I support the transition from |
agree |
- This PR adds the checks that are defined in the Makefile as pre-commit hooks. - Hopefully, the checks are equivalent to those from the Makefile, but I can't guarantee it. - CI remains as it is. - As I pointed out on discord, I experienced some conflicts between flake8 and yapf, so it might be better to transition to some other combination (e.g. black).