-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfixes: gym->gymnasium; render() update #769
Conversation
@Trinkle23897 PettingZoo*Tianshou tutorials are now live at https://pettingzoo.farama.org/tutorials/tianshou/beginner/ They pass CI, so there shouldn't be issues - if there are, feel free to check the workflow at: https://github.com/Farama-Foundation/PettingZoo/blob/master/.github/workflows/linux-tutorials-test.yml Or just pop me a ping :) Hope this clears up any confusion! |
Reid == @nrwahl2 :) Thanks, Will! |
When I run Traceback (most recent call last):
File "test/pettingzoo/test_tic_tac_toe.py", line 21, in <module>
test_tic_tac_toe(get_args())
File "test/pettingzoo/test_tic_tac_toe.py", line 17, in test_tic_tac_toe
watch(args, agent)
File "/home/trinkle/github/tianshou-new/test/pettingzoo/tic_tac_toe.py", line 240, in watch
result = collector.collect(n_episode=1, render=args.render)
File "/home/trinkle/github/tianshou-new/tianshou/data/collector.py", line 354, in collect
self.env.render()
File "/home/trinkle/github/tianshou-new/tianshou/env/venvs.py", line 355, in render
return [w.render(**kwargs) for w in self.workers]
File "/home/trinkle/github/tianshou-new/tianshou/env/venvs.py", line 355, in <listcomp>
return [w.render(**kwargs) for w in self.workers]
File "/home/trinkle/github/tianshou-new/tianshou/env/worker/dummy.py", line 49, in render
return self.env.render(**kwargs)
File "/home/trinkle/github/tianshou-new/tianshou/env/pettingzoo_env.py", line 150, in render
return self.env.render()
File "/home/trinkle/.local/lib/python3.8/site-packages/pettingzoo/utils/wrappers/order_enforcing.py", line 64, in render
return super().render()
File "/home/trinkle/.local/lib/python3.8/site-packages/pettingzoo/utils/wrappers/base.py", line 88, in render
return self.env.render()
File "/home/trinkle/.local/lib/python3.8/site-packages/pettingzoo/utils/wrappers/base.py", line 88, in render
return self.env.render()
File "/home/trinkle/.local/lib/python3.8/site-packages/pettingzoo/utils/wrappers/base.py", line 88, in render
return self.env.render()
File "/home/trinkle/.local/lib/python3.8/site-packages/pettingzoo/classic/tictactoe/tictactoe.py", line 231, in render
gymnasium.logger.WARN(
TypeError: 'int' object is not callable Also, can you add three links to tianshou's doc? Either create a subsection after multi-agent in cheatsheet, or just insert in that subsection |
Puckyle == @APN-Pucky I think pettingzoo should maybe directly link/copy this very useful tianshou tutorial https://tianshou.readthedocs.io/en/master/tutorials/tictactoe.html#tic-tac-toe-environment. |
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
- Coverage 91.24% 91.08% -0.16%
==========================================
Files 71 71
Lines 5082 5082
==========================================
- Hits 4637 4629 -8
- Misses 445 453 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Trinkle23897 Really sorry for the delay. I've just released 1.22.2 for PZ which deals with the WARN bug. |
Credits (names from the Farama Discord): - @nrwahl2 - @APN-Pucky - chattershuts
Credits (names from the Farama Discord):