Import Botocore from a more specific location #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing Botocore directly from `tornado_botocore.base` allows us to bypass the vague error message given by the library and see the actual import failure. Fixes #99
|
As far as I can tell this change doesn't change the supported versions. The In the end this change only clears up the error message. In my case and in the source for the issue in #99, the root cause for incompatibility was in missing dependencies down the stream. |
|
All right then, thanks for contributing! |
|
@sami9gag seems the tests are failing following your change, do you mind taking a look? (I'll try to see why circle didn't test your PR) |
|
My bad @sami9gag your change is not the cause of the tests failing |
|
I noticed that CircleCI didn't test my change, which seemed a bit odd. |
leviwilson
added a commit
to northwoodspd/serverless-image-handler
that referenced
this pull request
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing Botocore directly from
tornado_botocore.baseallows us to bypass the vague error message given by the library and see the actual import failure.Fixes #99