-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hashing support #243
hashing support #243
Conversation
Hi @pschrammel, what's the use case for hashing in the storage? |
It is a feature of TC_AWS that we were using for several reasons:
I switched from sha1 (original in TC_AWS) to sha256 as sha1 is regarded unsafe by our security scanners though in this case it wouldn't matter |
@guilhermef , I changed the concept, getting my very specific hashing is hard to get upstream. The idea now is that you can define a lambda expression that does your personal normalization magic. I hope this approach is more generic and easier to accept. |
Pull Request Test Coverage Report for Build 9775890186Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I need some help here to have hashing configurable