Fix image loading indicator #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
In #1074 I attempted to fix the image loading indicator, however, I changed it to match the wrong one and made it even worse! This PR is another attempt.
There is still a little hitch when it transfers from one indicator to the other, but we can address that later, and at least now they are the same style.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
loading_indicator_before.mp4
After
loading_indicator_after.mp4
Checklist
semanticLabels where applicable for accessibility?