-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/instance liveness indicators #655
Feature/instance liveness indicators #655
Conversation
That looks really good! I'm not at my computer to test out iOS but I like the latency indicator :D I can test it out when I have the chance |
One more change: I added special handling for failure to load posts. It mentions the possibility that the user may be offline or the instance may be down. It also offers a direct link to the settings where the user can add/switch accounts/instances. Hopefully this should alleviate issues where Thunder just spins forever on startup when an instance is down. Note that the snackbar will still display the "real" error message for troubleshooting. qemu-system-x86_64_YndXTkH8MW.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will wait for @hjiangsu or someone else to confirm that it works in iOS as expected.
…-liveness-indicators
@micahmo Tested this on iOS and it is also working as expected - I see both the status indicator and the measured ping times for each instance! |
Pull Request Description
This PR has a few changes related to instances on the profile page.
@hjiangsu For the ping to work on iOS, I found that we need to add an extra package and register on startup. I can't test that, so let me know if you can. Also a general note, the ping package doesn't work on Android emulators (not a big deal).
Issue Being Fixed
Issue Number: #628
Screenshots / Recordings
output.mp4
Checklist
semanticLabel
s where applicable for accessibility?