Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another comment spinner #672

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix another comment spinner #672

merged 1 commit into from
Aug 23, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 21, 2023

Pull Request Description

This PR fixes yet another issue with infinite deferred comment spinners. In this case, the problem was related to being at the end of the comments.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

spinner-before.mp4

After

spinner-after.mp4

Checklist

  • Did you update CHANGELOG.md? -- No I think we've mentioned this issue enough 😆
  • Did you use localized strings where applicable? -- N/A
  • Did you add semanticLabels where applicable for accessibility? -- N/A

ajsosa
ajsosa approved these changes Aug 23, 2023
View reviewed changes
lib/post/bloc/post_bloc.dart Show resolved Hide resolved
@ajsosa ajsosa merged commit 37c9c34 into thunder-app:develop Aug 23, 2023
1 check passed
@micahmo micahmo deleted the fix/deferred-comment-spinner branch August 24, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsosa ajsosa ajsosa approved these changes

@ggichure ggichure ggichure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micahmo @ggichure @ajsosa