Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved saved post star indicator before the title #684

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

ajsosa
Copy link
Collaborator

@ajsosa ajsosa commented Aug 24, 2023

Pull Request Description

Moved saved post star indicator so that it prefixes the title. This way it's consistent with the placement of the lock and featured community indicators for posts.

Capture

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! But now I'm a little bugged by the different relative sizes of the icons and the text. 😆 I took a swing at normalizing them. What do you think?

Before After
image image

If you like this, the sizes are 15, 17, and 15.

…so they are more consistent in size relative to eachother.
@ajsosa
Copy link
Collaborator Author

ajsosa commented Aug 25, 2023

Done!

@micahmo micahmo merged commit f172d2a into thunder-app:develop Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants