Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to not dim read posts #695

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Add option to not dim read posts #695

merged 6 commits into from
Sep 5, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 30, 2023

Pull Request Description

This PR adds an option which disables graying out read posts.

Issue Being Fixed

Issue Number: #663

Screenshots / Recordings

qemu-system-x86_64_2HDK2VLaIT.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable? -- N/A
  • Did you add semanticLabels where applicable for accessibility? -- N/A

hjiangsu
hjiangsu approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@micahmo
Copy link
Member Author

micahmo commented Sep 5, 2023

All set!

@hjiangsu hjiangsu merged commit 3844179 into thunder-app:develop Sep 5, 2023
1 check passed
@micahmo micahmo deleted the feature/no-dim-read branch September 23, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu