Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dismiss read #698

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Improve dismiss read #698

merged 1 commit into from
Aug 30, 2023

Conversation

CTalvio
Copy link
Collaborator

@CTalvio CTalvio commented Aug 30, 2023

Pull Request Description

This slightly improves dismiss read.

  • Animation staggering is now slightly longer in comfortable view, for a less jarring animation
  • Only read posts visible during the animation now get removed, rather than all read posts, including ones that become marked read soon after the animation completes, or load in with bad timing

Issue Being Fixed

Bad dismiss animation in comfortable view, inconsistency on what read posts get removed.

Checklist

N/A

micahmo
micahmo approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@micahmo micahmo merged commit 616793c into thunder-app:develop Aug 30, 2023
1 check passed
@CTalvio CTalvio deleted the improve_dismiss_read branch January 28, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahmo micahmo micahmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CTalvio @micahmo