Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve block management #704

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 5, 2023

Pull Request Description

This PR adds a few improvements around block management.

  1. Localize account settings page.
  2. Show community and user icons in block settings.
  3. Show display names.
  4. Make users/communities tappable to visit.
  5. New ability to add blocks directly from the settings page.
    • Including a new user/community picker dialog with support for autocomplete/search or direct name (via all of the syntax that we support in link detection).

P.S. I hope the username autocomplete can be used in the post/comment editor at some point (i.e., #256).

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

image

After

qemu-system-x86_64_Ft7pdXx9Ku.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@machinaeZER0
Copy link
Collaborator

Beautiful!

@hjiangsu
Copy link
Member

hjiangsu commented Sep 8, 2023

Looks pretty nice! Just a couple of suggestions:

  • Could we move the logic for the user/community autocomplete to their own separate widgets as a way for them to be re-used elsewhere in the future? This could be placed in the lib/shared directory!
  • Not sure if its just me, but I feel like theres a bit too much padding on the right side of the screen (where the add/remove icons are) Maybe we can reduce the padding there slightly?

@micahmo
Copy link
Member Author

micahmo commented Sep 9, 2023

Could we move the logic for the user/community autocomplete to their own separate widgets as a way for them to be re-used elsewhere in the future? This could be placed in the lib/shared directory!

Done!

I feel like theres a bit too much padding on the right side of the screen (where the add/remove icons are)

I agree! This seems to be a function of the ListTile's default contentPadding. I overrode that, and I think it's better now.

image

@hjiangsu
Copy link
Member

hjiangsu commented Sep 9, 2023

Looks good now! Thanks :D

@hjiangsu hjiangsu merged commit 6e22154 into thunder-app:develop Sep 9, 2023
1 check passed
@micahmo micahmo deleted the feature/improve-block-management branch September 10, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants