Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semantic label to combined FAB #713

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add semantic label to combined FAB #713

merged 1 commit into from
Sep 7, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 7, 2023

Pull Request Description

Fixes an issue reported by @shortwavesurfer2009 where the combined FAB had no semantic label.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

image

Checklist

  • Did you update CHANGELOG.md? -- N/A - new feature
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 76292c6 into thunder-app:develop Sep 7, 2023
1 check passed
@micahmo micahmo deleted the fix/combined-fab-semantic-label branch September 7, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu