Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usernames are not tappable when comments are collapsed #747

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 18, 2023

Pull Request Description

When comments are collapsed and the contents are hidden, usernames are not tappable to provide a bigger hitbox for reexpanding the comment.

Issue Being Fixed

Issue Number: #591

Screenshots / Recordings

qemu-system-x86_64_MNGUeQMYwu.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 9128347 into thunder-app:develop Sep 22, 2023
1 check passed
@micahmo micahmo deleted the fix/591-username-tap-when-collapsed branch September 23, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants