Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search reset bug #804

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 4, 2023

Pull Request Description

This PR fixes an issue where the first interaction with a community in the search results would accidentally reset search.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

search-fix-before.mp4

After

search-fix-after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit c933cc6 into thunder-app:develop Oct 4, 2023
1 check passed
@micahmo micahmo deleted the fix/search-bug branch October 5, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants