Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instance handling / login #810

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 6, 2023

Pull Request Description

This PR utilizes the new instance list in two ways.

  1. Check the list when determining whether a potential user/community link refers to a real Lemmy server for faster handling (we still have our slow API check method as a backup).
  2. Autocomplete instances when logging in.
    • Note that I did not prepopulate a default instance nor even showed the list as a dropdown. The list only appears to assist with autocomplete once the user has started typing. I did this to try to avoid pushing anyone to any particular instance (like the first in the list).

In addition to the above, I've added some links to the login page.

  • When no instance is selected, a Getting Started link will navigate to join-lemmy.org.
  • When an instance is selected, there's a link to open that instance in the browser, or go that instance's sign up page to make an account.

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_DGojNgg27U.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo force-pushed the feature/instance-list-things branch from a1c363f to 10f9613 Compare October 6, 2023 04:36
Copy link
Collaborator

@ggichure ggichure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 6a1457d into thunder-app:develop Oct 12, 2023
1 check passed
@micahmo micahmo deleted the feature/instance-list-things branch October 12, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants