Support new sort types #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
reviewed
Oct 19, 2023
|
BTW, it looks like 0.19 is broken in Thunder due to rc2 on voyager.lemmy.ml. I'll look into it! |
hjiangsu
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds support for the new post and comment sort types in Lemmy 0.19.x.
It also introduces a more general way to check whether the current instance supports a given feature.
See thunder-app/lemmy_api_client#6 for the API changes.
Issue Being Fixed
Related to #762.
Screenshots / Recordings
new-sort-types.mp4
Checklist
semanticLabels where applicable for accessibility?