Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support navigating to comments from within the app #835

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 17, 2023

Pull Request Description

This PR adds support for in-app comment navigation.

Issue Being Fixed

Previously, links to comments would open in the browser.

This should also help #832.

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_I0fpFXCaZQ.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo changed the title Support navigating to posts from within the app Support navigating to comments from within the app Oct 17, 2023
@micahmo micahmo force-pushed the feature/in-app-comment-navigation branch from 285d5be to dd40ec5 Compare October 17, 2023 14:49
@micahmo micahmo mentioned this pull request Oct 17, 2023
8 tasks
Copy link
Collaborator

@ggichure ggichure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit f636252 into thunder-app:develop Oct 17, 2023
1 check passed
@micahmo micahmo deleted the feature/in-app-comment-navigation branch October 18, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants