Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support suggested post titles #855

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 26, 2023

Pull Request Description

Following up on #843, this PR adds a feature of the web UI where, after inserting a link into the post, you may auto-populate the title field with a suggested title which is scraped from the URL.

Issue Being Fixed

Issue Number: #850

Screenshots / Recordings

qemu-system-x86_64_faf1eg0LXc.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member Author

micahmo commented Oct 27, 2023

This should still be good to go after the refactor!

Copy link
Collaborator

@ggichure ggichure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment!

lib/community/pages/create_post_page.dart Show resolved Hide resolved
@hjiangsu hjiangsu merged commit b2e6df4 into thunder-app:develop Oct 27, 2023
1 check passed
@micahmo micahmo deleted the feature/automatic-post-titles branch October 27, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants