Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments as supported search type #861

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add comments as supported search type #861

merged 1 commit into from
Nov 3, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Oct 29, 2023

Pull Request Description

This PR adds support for searching for comments.

Issue Being Fixed

Related to #273.

Screenshots / Recordings

qemu-system-x86_64_00waX7grxz.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just had one comment but that doesn't need to be done at this point in time!

lib/search/bloc/search_bloc.dart Show resolved Hide resolved
@hjiangsu hjiangsu merged commit cd59e7a into thunder-app:develop Nov 3, 2023
1 check passed
@micahmo micahmo deleted the feature/search-comments branch November 3, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu