Improve link handling in posts/comments #869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR improves the functionality of links within posts and comments.
There are a few caveats with this implementation.
a
element, all text surrounding a link on the same line becomes tappable. To handle this, I removed ouronTapLink
handler, which does solve the problem, but it also means that the text is not tappable in any capacity. That causes a small issue when viewing aCommentReference
because it means you can't tap on the text surrounding a link to navigate to the comment. You have to tap on another line or outside the body.Feel free to experiment to see what I mean by these issues, and if they're dealbreakers, I can keep working on it.
Issue Being Fixed
Issue Number: #309, #709
Screenshots / Recordings
qemu-system-x86_64_xfbhehNZpv.mp4
Checklist
semanticLabel
s where applicable for accessibility?