Add support for the UIDVALIDITY field in IMAP accounts #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhari991
force-pushed
the
uidvalidity-support
branch
from
51d9e2c
to
8496d69
Compare
Valodim
suggested changes
Mar 3, 2017
| @@ -167,6 +167,32 @@ public void open(int mode) throws MessagingException { | |||
| } | |||
| } | |||
|
|
|||
| public long getCurrentUidValidity() throws MessagingException { | |||
There was a problem hiding this comment.
can't this be done in an easier way by simply calling open if the folder is not yet opened? this already open the folder, and fetches a SelectOrExamineResponse, which can be used to parse and store the uidvalidity, so in cases the folder is already opened we don't have to do any server communication at all
| if (previousUidValidity != -1L && currentUidValidity != -1L && currentUidValidity != previousUidValidity) { | ||
|
|
||
| //Delete and reload all messages in the local folder | ||
| Set<String> localMessageUidSet = localFolder.getAllMessagesAndEffectiveDates().keySet(); |
There was a problem hiding this comment.
I wonder if it would be more appropriate to set the UIDs of all these messages to null, and leave deleting them to the normal syncing mechanism that relies on uids to do so. @cketti?
rhari991
force-pushed
the
uidvalidity-support
branch
from
0b461bc
to
01a617e
Compare
rhari991
force-pushed
the
uidvalidity-support
branch
from
01a617e
to
0646221
Compare
|
@Valodim made the change and added unit tests. |
|
Adding this as part of #2607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue : #1074
I tested this by creating a new folder in my email account, deleting it and recreating it with the same name. All the emails in the folder were reloaded.