Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies and target SDK #2914

Closed
wants to merge 2 commits into from
Closed

Updated dependencies and target SDK #2914

wants to merge 2 commits into from

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Nov 4, 2017

The build compiles this time. I'm still having trouble with gradle 4, but it's not really important to the project.

kotlin: 1.1.4-3 -> 1.1.51
expresso-core: 2.2.2 -> 3.0.1
splitwise autocomplete: 2.0.7 -> 2.0.8
glide: 3.6.1 -> 3.7.0
test runner: 0.4.1 -> 1.0.1

Required the following repo:
https://maven.google.com/
Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many things to be considered when updating build scripts. My advice for someone new to a project is to stay away from that in the beginning.

@@ -60,7 +64,7 @@ android {
versionName '5.303-SNAPSHOT'

minSdkVersion 15
targetSdkVersion 22
targetSdkVersion 26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the behavior of the framework. See e.g. #2110.

@cketti cketti closed this Nov 5, 2017
@jyn514 jyn514 deleted the versioning-stable branch November 5, 2017 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants