decouple client certificates from authentication #5115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice 👍 Can you please rebase on |
This allows the usage of client certificates to be independent of authentication. It is possible that the usage of client certificates eliminate the need for any authentication, or that they provide other benifits. This patch restructures the incoming and outgoing server setup pages so that client certificates can be set as long as the connection uses TLS/SSL. If the user chooses client certificates for authentication it will prompt for certificate only if there isn't one already set. Mixing password and client certificates works, and this builds upon other work that allows these settings to coexist in the imap/smtpURI. This also give the certificate spinner a little more polish. - label looks like other labels - some indentation - the cancel button only appears if there is something to cancel
|
done. let me know if you want me to flatten the commits. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the usage of client certificates to be independent of
authentication. It is possible that the usage of client certificates
eliminate the need for any authentication, or that they provide
other benifits.
This patch restructures the incoming and outgoing server setup pages
so that client certificates can be set as long as the connection uses
TLS/SSL. If the user chooses client certificates for authentication
it will prompt for certificate only if there isn't one already set.
Mixing password and client certificates works, and this builds upon
other work that allows these settings to coexist in the imap/smtpURI.
This also give the certificate spinner a little more polish.
Happy to get feedback. I reviewed the other attempts at this, and the only thing
that this lacks is the ability to use auth external without tls/ssl, which I could
implement, but I don't think there's a valid use case for that.
This PR requires a new decoder/encoder that can full persist these serversettings, as
the old uri format isn't up for the job. I'm happy to help coding a the new encoder/decoder
as well as a preference migrations routine if that help is desired.