Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pr.txt files does not match the curve in the paper #5

Closed
pfllo opened this issue Aug 22, 2016 · 4 comments
Closed

The pr.txt files does not match the curve in the paper #5

pfllo opened this issue Aug 22, 2016 · 4 comments

Comments

@pfllo
Copy link

pfllo commented Aug 22, 2016

Hi,

I'm trying to reproduce the PR curves in the paper. However I find that the pr.txt files in the repository does not match the curves reported in the paper (PCNN+ATT for example).

Are these files generated by models that are not fully trained?
Can you provide pr.txt files that can reproduce curves in the paper?

Much appreciated.

@SharmisthaJat
Copy link

SharmisthaJat commented Aug 22, 2016

I have the same question. pr-1.txt has 2000 lines, shouldn't it have more than ~96k lines (more than one prediction for each entity pair in test file). I changed line 237 of test.h to {for (int i=0; i<int(aa.size()); i++)} which results in ~96k*52 lines in pr.txt. But, the graph still does not match. I am plotting column 2 and 3 (recall and precision I assume) of pr-1.txt for the curve, is that the correct interpretation?

It will be very helpful if you could provide us with a script to generate the PR curve.

Thanks

@Mrlyk423
Copy link
Member

I have updated the test.h in PCNN+ATT. And the original pr.txt and models of our experiments can be downloaded in https://pan.baidu.com/s/1bo0fgXx.

@pfllo
Copy link
Author

pfllo commented Aug 23, 2016

Thank you! @Mrlyk423
This helps a lot!

@SharmisthaJat
Copy link

Thanks for your response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants