Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add new workflow documents #1174

Merged
merged 9 commits into from
Jun 19, 2023
Merged

docs: add new workflow documents #1174

merged 9 commits into from
Jun 19, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jun 5, 2023 •
edited
Loading

Update the PR workflow to builtin lgtm + approve plugins.

@ti-chi-bot ti-chi-bot bot requested review from Mini256 and purelind June 5, 2023 10:58
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023 •
edited
Loading

🎊 PR Preview dce5f0e has been successfully built and deployed to https://ti-community-infra-tichi-preview-pr-1174.surge.sh

🕐 Build time: 0.014s

🤖 By surge-preview

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 5, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@wuhuizuo
docs: add new workflow documents
91b60ea 
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 5, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 5, 2023

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 5, 2023
@wuhuizuo wuhuizuo mentioned this pull request Jun 5, 2023
Closed
Mini256
Mini256 reviewed Jun 6, 2023
View reviewed changes
docs/en/workflows/pr.md Outdated Show resolved Hide resolved
docs/en/workflows/pr.md Outdated Show resolved Hide resolved
@wuhuizuo
docs: update new workflow documents en edition
6c932ad 
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo force-pushed the docs/new-workflow branch 2 times, most recently from d948886 to 01fd3e1 Compare June 7, 2023 08:54
@wuhuizuo
docs: update new workflow documents
445ed86 
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 7, 2023

fixed, please review it again 🌹 @Mini256

Mini256
Mini256 reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@Mini256 Mini256 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also suggest to request review to the R&D team.

@wuhuizuo I did not have an actual experience with this new workflow, so I cannot judge whether the document description is sufficient.

@hawkingrei, @bb7133 @hi-rustin Could you mind take a look at this PR in your free time.

I think this document will not only be used by the R&D team, but also for guiding developers' contributions. This is worth further review.

docs/_sidebar.md Outdated Show resolved Hide resolved
docs/en/workflows/pr.md Outdated Show resolved Hide resolved
docs/en/workflows/pr.md Outdated Show resolved Hide resolved
docs/en/workflows/pr.md Outdated Show resolved Hide resolved
wuhuizuo and others added 3 commits June 8, 2023 23:58
@wuhuizuo @Mini256
Update docs/_sidebar.md
5d9b843 
Co-authored-by: Mini256 <minianter@foxmail.com>
@wuhuizuo @Mini256
Update docs/en/workflows/pr.md
a55cf13 
Co-authored-by: Mini256 <minianter@foxmail.com>
@wuhuizuo @Mini256
Update docs/en/workflows/pr.md
edaf4a2 
Co-authored-by: Mini256 <minianter@foxmail.com>
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 8, 2023

/approve cancel

need more reviews.

@ti-chi-bot ti-chi-bot bot removed the approved label Jun 8, 2023
purelind
purelind approved these changes Jun 19, 2023
View reviewed changes
Copy link

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-19 06:04:31.144580173 +0000 UTC m=+584067.559184253: ☑️ agreed by purelind.

@wuhuizuo
Copy link
Contributor Author

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 19, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8d3686d into master Jun 19, 2023
@ti-chi-bot ti-chi-bot bot deleted the docs/new-workflow branch June 19, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mini256 Mini256 Mini256 left review comments

@purelind purelind purelind approved these changes

Assignees

@purelind purelind

Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wuhuizuo @Mini256 @purelind