Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor request -> axios #4

Closed
tiagosiebler opened this issue Jul 21, 2020 · 0 comments · Fixed by #15
Closed

Refactor request -> axios #4

tiagosiebler opened this issue Jul 21, 2020 · 0 comments · Fixed by #15
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tiagosiebler
Copy link
Owner

tiagosiebler commented Jul 21, 2020 •
edited
Loading

Request is deprecated for a while now. Need to refactor the library to leverage axios for requests. This will also reduce bundle size significantly.

https://github.com/axios/axios
@tiagosiebler tiagosiebler added enhancement New feature or request help wanted Extra attention is needed labels Jul 21, 2020
tiagosiebler pushed a commit that referenced this issue Oct 4, 2020
feat: deprecate request and implement axios. bump ws. cleaning. expos…
3a2125e 
…e request options for proxy support. resolves #12. resolves #4.
@tiagosiebler tiagosiebler mentioned this issue Oct 4, 2020
Merged
9 tasks
tiagosiebler pushed a commit that referenced this issue Feb 16, 2021
@peepo5
Merge pull request #4 from tiagosiebler/wsclean
2363994 
address codefactor suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated request with axios tiagosiebler/bybit-api
1 participant
@tiagosiebler