change when you initialize the requestwrapper to pass along the restI… #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nverseOptions to getBaseUrl currently the ability to pass your own baseUrl is not working
tiagosiebler
requested changes
Feb 18, 2021
There was a problem hiding this comment.
Good catch! I missed that in my last refactor. Can you also do this in the linear client? The param name is a bit misleading there but it works the same way.
Last but not least, please also bump the version in the package json to 2.0.1. That'll push to npm once this gets merged. Thanks!
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change when you initialize the requestwrapper to pass along the restInverseOptions to getBaseUrl currently the ability to pass your own baseUrl is not working.
I don't know Typescript but I'm assuming this is the correct fix