Fix the return value of the isVeryLong function #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndexes), but the library handle it one per variable, what duplicate it. So, what we have is just a list of the current variables where only the last one (the current) that create the valuelabel, is related with it. So, find if we need to convert the string to double there, because the indexes are pointing to the place where the variable will be stored, not to the variable itself.
… indicate, we can not let it to have a variable size unless the size is the unicode length that is what pack * is doing internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit seem to be all that is needed to fix the issue #56, but but i also wrote there some other things that could cause issues in the future, like a comparation with an array or an appartently wrong comment in the code. I will handle also here that other problematics.