Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix set varchar limit when max_length is set on Pydantic models using Pydantic v2 #963

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

estebanx64
Copy link
Member

No description provided.

@tiangolo tiangolo changed the title 🐛 Fix varchar set limit when max_length is set on pydantic models 🐛 Fix set varchar limit when max_length is set on Pydantic models using Pydantic v2 Jun 4, 2024
@tiangolo
Copy link
Member

tiangolo commented Jun 4, 2024

Great, thanks! 🚀

I moved the import of annotated_types to the Pydantic v2 section as it is required only by Pydantic v2 but not by Pydantic v1.

I still don't have something in the CI tests to check for those cases, I should add that. 🤔

But this is done, great job, thank you! 🚀

@tiangolo tiangolo added the bug Something isn't working label Jun 4, 2024
@tiangolo tiangolo enabled auto-merge (squash) June 4, 2024 00:38
@tiangolo tiangolo merged commit 5bb4cff into main Jun 4, 2024
22 checks passed
@tiangolo tiangolo deleted the FL-389-fix-database-string-max-length branch June 4, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants