Skip to content

🐛 Fix set varchar limit when max_length is set on Pydantic models using Pydantic v2 #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2024
Merged

🐛 Fix set varchar limit when max_length is set on Pydantic models using Pydantic v2 #963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e711688
🐛 Fix varchar set limit when max_length is set on pydantic models
estebanx64 Jun 3, 2024
1cca507
♻️ Move annotated_types import to Pydantic v2 only, as it is a depend…
tiangolo Jun 4, 2024
db24d60
Merge branch 'main' into FL-389-fix-database-string-max-length
tiangolo Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sqlmodel/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def partial_init() -> Generator[None, None, None]:


if IS_PYDANTIC_V2:
from annotated_types import MaxLen
from pydantic import ConfigDict as BaseConfig
from pydantic._internal._fields import PydanticMetadata
from pydantic._internal._model_construction import ModelMetaclass
Expand Down Expand Up @@ -201,7 +202,7 @@ def get_type_from_field(field: Any) -> Any:

def get_field_metadata(field: Any) -> Any:
for meta in field.metadata:
if isinstance(meta, PydanticMetadata):
if isinstance(meta, (PydanticMetadata, MaxLen)):
return meta
return FakeMetadata()

Expand Down