edk2_invocable: print help message when build module provided #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made in tianocore#639 to ensure the invocable displayed their command line arguments when a build module was not provided failed to test the critical scenario of ensuring the help message was still displayed when a build module was provided. The help command line argument is consumed during the first pass of the command line argument parser, so when the build module is found, registered, and the parser is re-executed, the help argument is no longer present to trigger the help message display. This commit fixes the issue by adding the "--help" command line argument to the arguments to be parsed if it was detected in the first parse.
makubacki
approved these changes
Dec 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 78.73% 78.73%
=======================================
Files 49 49
Lines 4853 4853
=======================================
Hits 3821 3821
Misses 1032 1032
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in #639 to ensure the invocable displayed their command line arguments when a build module was not provided failed to test the critical scenario of ensuring the help message was still displayed when a build module was provided.
The help command line argument is consumed during the first pass of the command line argument parser, so when the build module is found, registered, and the parser is re-executed, the help argument is no longer present to trigger the help message display.
This commit fixes the issue by adding the "--help" command line argument to the arguments to be parsed if it was detected in the first parse.
closes #708