-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ruff issues [Rebase & FF] #646
Conversation
@Javagedes, it seems strange this wasn't done already. Was there a reason? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
==========================================
- Coverage 81.43% 81.31% -0.13%
==========================================
Files 56 45 -11
Lines 7514 7486 -28
==========================================
- Hits 6119 6087 -32
- Misses 1395 1399 +4 ☔ View full report in Codecov by Sentry. |
@makubacki you ran Also, I'm not sure why the single to double quotes rule was applied. That is Q000 and I don't have that rule set enabled. |
That makes sense. I'd prefer we just run it on the whole workspace. It better encompasses the goals of formatting imo to have all the code consistent. I'm also trying to figure the quote thing out. |
86eada9
to
ab2f27a
Compare
Pushed two times without realizing the last commit was silently undoing what I kept amending into the second commit to fix CI. It should actually work now. |
Addresses these deprecated messages from ruff: ``` warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`: - 'ignore' -> 'lint.ignore' - 'select' -> 'lint.select' - 'flake8-annotations' -> 'lint.flake8-annotations' - 'pydocstyle' -> 'lint.pydocstyle' ``` Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Runs `ruff format .` on the workspace. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Allows ruff to pass in the repo with no problem. Since these are unit tests, no investment is made to change behavior of the exception handler. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
ab2f27a
to
092ce53
Compare
pyproject.toml: Update ruff deprecated settings
Addresses these deprecated messages from ruff:
Fix ruff issues
Runs
ruff format .
on the workspace.test.unit: Prevent bare except ruff errors
Allows ruff to pass in the repo with no problem. Since these are unit
tests, no investment is made to change behavior of the exception
handler.
Note: @Javagedes is going to follow up with a PR to update additional documentation and checks for using
ruff format
moving forward.