BaseTools: Ecc disable ascii scan #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leiflindholm
requested review from
a user,
lgao4,
BobCF,
mdkinney,
ajfish,
makubacki and
YuweiChen1110
mdkinney
approved these changes
Jul 11, 2024
leiflindholm
force-pushed
the
ecc-disable-ascii-scan
branch
from
acc19da
to
7866995
Compare
Ecc concistently referred to ASCII/Ascii as ACSII/Acsii, which bugged me to no end when trying to figure out how those tests worked. Fix all instances. Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
The GeneralCheckNonAscii() function is a sledgehammer rejecting any file containing any character outside of the 7-bit ASCII encoding space, as well as the DEL character (which seems unrelated). This conflicts with basic stuff like correctly spelling certain proper nouns in comments (like copyright statements), or string literals (for example in multi-language driver binding ComponentNames). So rip it out, to be replaced by more fine-grained checks to be added as identified and needed. Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
leiflindholm
force-pushed
the
ecc-disable-ascii-scan
branch
from
7866995
to
3d93025
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the discussion in #5893, replacing #5867 based on conversation with @mdkinney and @ajfish.
The conversation on what to do with regards to the style rules will be a longer one. This change lets us merge #5840 while that conversation is ongoing.
Patch 1/2 still fixes a consistent misspelling of ASCII in ECC.
Patch 2/2 now completely deletes the GeneralCheckNoAscii() test from ECC. However, there are some other tests that still verify (via regex) various identifiers against naming standards from the coding style, enforcing a subset of ASCII there.
My intent is to follow this PR with one adding ASCII-checks for remaining identifier types, as an RFC.