Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for swarm-mode (1.12) #20

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

matthid
Copy link

@matthid matthid commented Mar 27, 2017

Note: This is my first time doing go-programming, so please be kind :)

Will add some documentation on how to use this after I verified that it works for my use case. My plan is to integrate this into a swarm mode (1.12) cluster to be able to "hook" some domain suffixes to my containers (mainly for swarm internal tls certificate verification to work).

Note: #15 would be nice to have for my use-case as well :)

@matthid
Copy link
Author

matthid commented Mar 27, 2017

Maybe "type": "services", would be a better approach?

@matthid matthid changed the title WIP: Add support for swarm-mode (1.12) Add support for swarm-mode (1.12) Mar 29, 2017
@matthid
Copy link
Author

matthid commented Mar 29, 2017

@tianon Let me know what you think. This is now working and in-use on my system.

@sergey-tikhonenko
Copy link

Hello, I'm looking for Swarm mode too, are you going to merge this?

@tianon
Copy link
Owner

tianon commented Aug 21, 2017

Sorry for the really long delay, @matthid! I do like the idea of adding swarm support, but I agree that "type": "services" would make more sense -- the current "swarm" support was based on the legacy swarm mode where everything was still containers (and more importantly, was using the "container inspect" API), so switching to a completely separate type for looking up IP information for services makes sense (and makes it clear which API endpoint we need to hit, avoiding the docker inspect issue where it has to loop over API endpoints until it finds the right one).

If you've lost interest in this, I totally understand, and am happy to take over. ❤️

@matthid
Copy link
Author

matthid commented Aug 21, 2017

@tianon No, actually I'm glad to hear this is not dead. I even got a PR on my fork, but wasn't ready to take it (ie. fork this project - because of many other projects I'm involved).

We can continue with whatever is easier for you - either take over or tell me what to do to get it in (though I'm a absolute go beginner, but happy to learn :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants