Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the responsibility of skipping disabled fighter collisions to the Engine #2

Merged

Conversation

Amazinite
Copy link

Why do you have a branch named "fighter-daddy-issues"?

@tibetiroka
Copy link
Owner

Why do you have a branch named "fighter-daddy-issues"?

It's for another (open) pr about fighter parenting.

@tibetiroka
Copy link
Owner

I'm going to assume that you tested this and it doesn't bork anything else. Just to make sure, this does still trigger weapons with trigger radius near the fighters, correct?

@Amazinite
Copy link
Author

Yes. The collision type for trigger radius explosions is NONE and the hit pointer is nullptr, meaning shipHit will be false.

@tibetiroka tibetiroka merged commit 8110c5e into tibetiroka:fighter-phasing Mar 12, 2024
@Amazinite Amazinite deleted the 0.10.7-collision-set-update branch March 12, 2024 08:21
tibetiroka pushed a commit that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants