Fix broken keybindings (i.e. n, k) and adjust Readme to current keybindings #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52986cf.
|
Hi Cristian Thanks for your quick response. I double-checked qgit on my machine (;-) ) and in fact, the keys are remapped to ctrl-r/ctrl-t somehow. See screenshot ). But I can see in the code that it's actually using r/p by default. Not sure how and by what component this remapping is done but maybe it's KDE specific. Anyhow, in order to get the actual fix merged, I reverted commit 52986cf . Thx and cheers |
|
Hey Urs
There are both explicit accelerators (in the code you patched) and QAction
objects, in which the Ctrl+* key combinations are defined. I don't think
this is harmful.
I'll pull your request ASAP.
Thanks again
Cristian
…On 28 May 2017 at 23:57, Urs Joss ***@***.***> wrote:
Hi Cristian
Thanks for your quick response. I double-checked qgit on my machine (;-) )
and in fact, the keys are remapped to ctrl-r/ctrl-t somehow. See
screenshot
<https://github.com/ursjoss/qgit/blob/tb_screenshot/tmp/qgit_keymappings.png>
). Not sure how and by what component this remapping is done but maybe it's
KDE specific.
Anyhow, in order to get the actual fix merged, I reverted commit 52986cf
<52986cf>
.
Thx and cheers
Urs
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABLrDh3PuWgXqRLhlArtBzCday_aBRCrks5r-kImgaJpZM4NkJcj>
.
|
|
Thanks Cristian. Cheers, Urs |
gameltb
added a commit
to gameltb/qgit
that referenced
this pull request
Nov 4, 2019
Signal: 11 (SEGV)
Stack trace:
#0 0x00007febea253c02 __strcmp_avx2 (libc.so.6)
tibirna#1 0x0000561c9b6cc115 _ZNK5QHashI9ShaStringPK7RevFileE8findNodeERKS0_j (qgit)
tibirna#2 0x0000561c9b6f5397 _ZN3Git13loadFileNamesEv (qgit)
tibirna#3 0x00007febea77eac1 _ZN11QMetaObject8activateEP7QObjectiiPPv (libQt5Core.so.5)
tibirna#4 0x00007febea78bd44 n/a (libQt5Core.so.5)
tibirna#5 0x00007febea77f495 _ZN7QObject5eventEP6QEvent (libQt5Core.so.5)
tibirna#6 0x00007febeb10c4e5 _ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent (libQt5Widgets.so.5)
tibirna#7 0x00007febeb115e11 _ZN12QApplication6notifyEP7QObjectP6QEvent (libQt5Widgets.so.5)
tibirna#8 0x00007febea752d12 _ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent (libQt5Core.so.5)
tibirna#9 0x00007febea7a9ead _ZN14QTimerInfoList14activateTimersEv (libQt5Core.so.5)
tibirna#10 0x00007febea7aa742 n/a (libQt5Core.so.5)
tibirna#11 0x00007febe942d3ee g_main_context_dispatch (libglib-2.0.so.0)
tibirna#12 0x00007febe942f201 n/a (libglib-2.0.so.0)
tibirna#13 0x00007febe942f241 g_main_context_iteration (libglib-2.0.so.0)
tibirna#14 0x00007febea7aab13 _ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE (libQt5Core.so.5)
tibirna#15 0x00007febea75183c _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE (libQt5Core.so.5)
tibirna#16 0x00007febea759676 _ZN16QCoreApplication4execEv (libQt5Core.so.5)
tibirna#17 0x0000561c9b6b63a1 main (qgit)
tibirna#18 0x00007febea11e153 __libc_start_main (libc.so.6)
tibirna#19 0x0000561c9b6b647e _start (qgit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I noticed that in qgit-2.7 some of the key bindings did not work anymore. Especially n/k (to move down one revision) not working was quite annoing and prevented me from upgrading.
I also adjusted the readme to reflect the current keybindings for going to revisions page (r -> CTRL-r) and to the patch page (p -> CTRL-p). There might be different mismatches, but most keys I did try with the patched versions were doing what I expected.
Thanks and cheers
Urs