Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in cocoainitializer class to prevent mem leaks on Cocoa-based Macs #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding in cocoainitializer class to prevent mem leaks on Cocoa-based Macs #91

wants to merge 1 commit into from

Conversation

NucleaPeon
Copy link

  • Ignore .DS_Store folder setting files, src/qmake when building in tree
  • added name to about contributors

@NucleaPeon
Adding in cocoainitializer class to prevent mem leaks on Cocoa-based …
5d4fe75 
…Macs

  - Ignore .DS_Store folder setting files, src/qmake when building in tree
  - added name to about contributors

Signed-off-by: Daniel Kettle <danielk@bigleaf.net>
@NucleaPeon NucleaPeon mentioned this pull request Mar 15, 2020
Open
@tibirna
Copy link
Owner

tibirna commented Mar 23, 2020 •
edited
Loading

What is the license on the cocoainitializer.{h,mm} files? Headers indicate authors other than you.

@NucleaPeon
Copy link
Author

NucleaPeon commented Mar 23, 2020 •
edited
Loading

Sharp eye.
I pulled the code from https://github.com/torrent-file-editor/torrent-file-editor.
License file reports GPL 3.0 https://github.com/torrent-file-editor/torrent-file-editor/blob/master/LICENSE

Edit (clarification)

I didn't write it, I left in the previous authors.
I attempted to find a fix for the same issue on a project I'm working on.
In an obscure mailing list, I found a reference to CocoaInitializer. Searching for it, I found a github result that had those two files in it. I'm not sure if the repo owners wrote it themselves, but information was sparse and it fixed my issue.

The QT developers dismissed the NS pool memory autorelease issue, saying 5.3.1/2 was no longer going to be supported for snow leopard going forward and I haven't seen the issue on much later versions of OS X (10.11)

@filiperinaldi
Copy link
Contributor

I haven't seen the issue on much later versions of OS X

I suppose this PR is no longer relevant then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NucleaPeon @tibirna @filiperinaldi