Plugin Settings #19
Merged
Plugin Settings #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d config.class.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new database table to hold plugins settings (to be developed). Settings form will be a tab in General Setup settings page. For now, the only option is to enable or not the timer in tasks (basically, enable or not the plugin), default to Enabled. If you disable it, no data is lost, but timer buttons and statistics does not appear.
For Glpi to update the database, the plugin version was increase to 1.1.1. That way, updating plugin directory will show the upgrade option on Setup - Plugins page, needed to get the database change. No timer's data for the tasks will be lost.