Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put a sleep in code to getPendings from GLPI can list the queue #9

Closed
wants to merge 1 commit into from

Conversation

fgendorf
Copy link

Because the inside function on GLPI getPendings use just < on filter, the notification just created, less than 1 second is not available yet.
Put a sleep(1); before call QueuedNotification::forceSendFor is enough to send the OTP immediately.

If the GLPI team adjust the filter in getPendings to <= this PR is not necessary

@OscarBeiro OscarBeiro added the bug Something isn't working label Nov 30, 2023
@fgendorf
Copy link
Author

fgendorf commented Dec 13, 2023

The GLPI project accept my PR to change the filter of getPendings from '<' to '<='
Next release this PR on MFA became useless

glpi-project/glpi#16173

@OscarBeiro
Copy link
Contributor

OscarBeiro commented Dec 13, 2023 via email

@fgendorf
Copy link
Author

Accepted, but not merged yet... maybe on 10.0.12...

@fgendorf fgendorf closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants