Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When I hit Ctrl+Enter, it evaluates but also inserts a new line in the editor (same as pressing Enter) (Chrome, Linux, Ubuntu) #122

Closed
munshkr opened this issue May 30, 2022 · 2 comments
Closed

When I hit Ctrl+Enter, it evaluates but also inserts a new line in the editor (same as pressing Enter) (Chrome, Linux, Ubuntu) #122

munshkr opened this issue May 30, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@munshkr
Copy link
Member

munshkr commented May 30, 2022

  • Browser: Google Chrome 101.0.4951.64
  • OS: Ubuntu
@munshkr munshkr added the bug Something isn't working label May 30, 2022
felixroos added a commit that referenced this issue Jun 1, 2022
@felixroos
Merge pull request #124 from tidalcycles/ctrl-enter-fix
e2c4a3b 
fix: #122 ctrl enter would add newline
@munshkr
Copy link
Member Author

munshkr commented Jun 1, 2022

Thanks!

felixroos added a commit that referenced this issue Jun 1, 2022
@felixroos
fix: #122 was still not fixed for async patterns
5cd80b5
@felixroos
Copy link
Collaborator

thanks for reporting! just had to add another little fix for async patterns, now it should work in all cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@munshkr @felixroos