make --watch work with vim #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vim appears to move/rename the original file on save, resulting in a RENAME event from fsnotify. Reacting to this by re-adding the original file name also catches two CHMOD (but no WRITE). Not sure what's going on, but re-adding on RENAME and reloading on CHMOD seems to do the trick.
|
Hey @mackorone, were you by any chance using vim when you ran into issue #16? I was able to repro this with vim on both ubuntu and macOS, but not with e.g emacs or Not the most elegant solution, but seems to do the trick for now. |
|
Yep, I was using Vim. Good catch! |
rohansingh
approved these changes
Dec 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vim appears to move/rename the original file on save, resulting
in a RENAME event from fsnotify. Reacting to this by re-adding
the original file name also catches two CHMOD (but no WRITE).
Not sure what's going on, but re-adding on RENAME and reloading
on CHMOD seems to do the trick.