Test coverage #14
Merged
Test coverage #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library of choice is `cloverage`. It seems quite nice.
By wrapping all tests in `deftest`, they work with both `lein midje` and `lein test`. This makes interoperability with cloverage much easier (and also means people expecting `lein test` to work will not be disappointed.)
This simply tests whether it runs without error. It does not address the quality of the output. This is a good first step towards issue #13.
|
I will take the liberty of merging my own pull request in, as this is rather crucial to bringing the master branch back to a state where builds do not fail. |
emiln
added a commit
that referenced
this pull request
Feb 15, 2014
Hopefully this brings `master` back on track.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage using cloverage and coveralls.io.
I had to refactor existing tests so they now work with either
lein midjeorlein test. This made them slightly less pretty, but provides excellent support for many libraries assuming the use of the standard test library.To improve our poor coverage slightly, I took the liberty of testing
tip.core/-mainas well.