Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2395] Add GA4 page view and sign up redirect tracking #1240

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[WEB-2395] Add GA4 page view and sign up redirect tracking #1240

wants to merge 6 commits into from
+62 −3

Conversation

clintonium-119
Copy link
Member

@clintonium-119 clintonium-119 commented May 31, 2023 •
edited
Loading

This was referenced May 31, 2023
Merged
Merged
@clintonium-119 clintonium-119 changed the base branch from develop to master May 31, 2023 16:39
krystophv
krystophv requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple small concerns. Lemme know if you disagree or if I've missed something.

app/pages/signup/signup.js Show resolved Hide resolved
app/routes.js Outdated Show resolved Hide resolved
@clintonium-119
Copy link
Member Author

clintonium-119 commented Jun 1, 2023 •
edited
Loading

@krystophv I've gone and moved the GA init and pageview logic to a wrapper component. I think it's better than the vanity route we were going to settle with. Requesting re-review.

krystophv
krystophv approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystophv krystophv krystophv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clintonium-119 @krystophv